Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query serving: incorporate mirror query results in log stats, fix mirror query max lag bug #16879

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Query serving: incorporate mirror query results in log stats, fix mirror query max lag bug #16879

merged 2 commits into from
Oct 6, 2024

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Oct 2, 2024 •
edited
Loading

Description

This PR adds a few new fields to log stats to provide visibility into traffic mirroring. The idea behind traffic mirroring is to see if the target of a VReplication workflow will perform as well as the source when queries are sent to it. In order to make that determination, we can send mirrored queries to the target with MirrorTraffic. However, we also need a way to compare the query execution times and errors of the source vs. target queries.

While working on this PR, I noticed a bug with how mirror target queries are bounded. The VTGate mirror primitive was written with the intention of having the mirror target be canceled if it continues executing for too long (hardcoded at 100ms) after the source primitive finishes executing. However as it is currently written the mirror target will be canceled if it executes for more than 100ms. This PR fixes that.

Related Issue(s)

Fix #16877
Close #16878
Close #13772

Checklist

Deployment Notes

None

@maxenglander
fix bug, add tests
b3d21ea 
Signed-off-by: Max Englander <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 2, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 2, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Oct 2, 2024
@maxenglander maxenglander mentioned this pull request Oct 2, 2024
Merged
@maxenglander maxenglander added Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 2, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.43%. Comparing base (978c59d) to head (aff7830).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16879   +/-   ##
=======================================
  Coverage   69.43%   69.43%           
=======================================
  Files        1571     1571           
  Lines      203195   203237   +42     
=======================================
+ Hits       141079   141119   +40     
- Misses      62116    62118    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxenglander maxenglander marked this pull request as ready for review October 2, 2024 18:15
@systay systay removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Oct 3, 2024
GuptaManan100
GuptaManan100 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Oct 4, 2024
Closed
57 tasks
@rohit-nayak-ps rohit-nayak-ps merged commit b6be2ee into vitessio:main Oct 6, 2024
98 of 99 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the maxeng-mirror-logstats branch October 6, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v21.0.0
4 participants
@maxenglander @systay @GuptaManan100 @rohit-nayak-ps